Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Fix more ESLint errors #2738

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix more ESLint errors #2738

merged 1 commit into from
Sep 16, 2021

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 16, 2021

What it solves

Solves pending ESLint issues

@dasanra dasanra requested a review from mmv08 September 16, 2021 14:59
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 10 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 10 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@@ -1,5 +1,5 @@
import { withStyles } from '@material-ui/core/styles'
import * as React from 'react'
import { ReactElement } from 'react'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can actually access it via React.ReactElement without importing, React namespace is available globally for types

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You grep-fu is superior

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

E2E Tests Passed
Check the results here: https://github.com/gnosis/safe-react-e2e-tests/actions/runs/1242129325

@dasanra dasanra merged commit 1e5df65 into dev Sep 16, 2021
@dasanra dasanra deleted the fix/cleanup-more-eslint-errors branch September 16, 2021 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants